demo(release): Add release tester from demo site and update JSDOC guide#3297
Conversation
jolevesq
left a comment
There was a problem hiding this comment.
@jolevesq reviewed 12 files and all commit messages, and resolved 3 discussions.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on Alex-NRCan, DamonU2, kenchase, and MatthewMuehlhauserNRCan).
kenchase
left a comment
There was a problem hiding this comment.
@kenchase made 1 comment.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on Alex-NRCan, DamonU2, and MatthewMuehlhauserNRCan).
DamonU2
left a comment
There was a problem hiding this comment.
@DamonU2 reviewed 13 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Alex-NRCan, jolevesq, and MatthewMuehlhauserNRCan).
CONTRIBUTING.md line 90 at r4 (raw file):
* Add RCS config layers to configuration after startup has finished * * @param keys - Uptional list of keys marking which layers to retrieve
Uptional > Optional
.github/copilot-instructions.md line 239 at r4 (raw file):
* It dispatches an event to the EventProcessor, which * will trigger the appropriate GeoView API call. *
This blank line is not represented in the list above
jolevesq
left a comment
There was a problem hiding this comment.
@jolevesq reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Alex-NRCan, DamonU2, and MatthewMuehlhauserNRCan).
CONTRIBUTING.md line 90 at r4 (raw file):
Previously, DamonU2 (Damon Ulmi) wrote…
Uptional > Optional
Done.
.github/copilot-instructions.md line 239 at r4 (raw file):
Previously, DamonU2 (Damon Ulmi) wrote…
This blank line is not represented in the list above
Done.
DamonU2
left a comment
There was a problem hiding this comment.
@DamonU2 reviewed 5 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Alex-NRCan and MatthewMuehlhauserNRCan).
Alex-NRCan
left a comment
There was a problem hiding this comment.
@Alex-NRCan reviewed 13 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on MatthewMuehlhauserNRCan).
777e2a1
into
Canadian-Geospatial-Platform:develop
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
hosted Feb 23, 15:30
https://jolevesq.github.io/geoview/release-navigator.html
https://jolevesq.github.io/geoview/wcag.html
Checklist:
I have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is