Skip to content

demo(release): Add release tester from demo site and update JSDOC guide#3297

Merged
jolevesq merged 5 commits intoCanadian-Geospatial-Platform:developfrom
jolevesq:demo-rel
Feb 24, 2026
Merged

demo(release): Add release tester from demo site and update JSDOC guide#3297
jolevesq merged 5 commits intoCanadian-Geospatial-Platform:developfrom
jolevesq:demo-rel

Conversation

@jolevesq
Copy link
Member

@jolevesq jolevesq commented Feb 23, 2026

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

hosted Feb 23, 15:30
https://jolevesq.github.io/geoview/release-navigator.html

https://jolevesq.github.io/geoview/wcag.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation~~
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

Copy link
Member Author

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jolevesq reviewed 12 files and all commit messages, and resolved 3 discussions.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on Alex-NRCan, DamonU2, kenchase, and MatthewMuehlhauserNRCan).

Copy link
Contributor

@kenchase kenchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@kenchase made 1 comment.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on Alex-NRCan, DamonU2, and MatthewMuehlhauserNRCan).

Copy link
Member

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamonU2 reviewed 13 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Alex-NRCan, jolevesq, and MatthewMuehlhauserNRCan).


CONTRIBUTING.md line 90 at r4 (raw file):

         * Add RCS config layers to configuration after startup has finished
         *
         * @param keys - Uptional list of keys marking which layers to retrieve

Uptional > Optional


.github/copilot-instructions.md line 239 at r4 (raw file):

 * It dispatches an event to the EventProcessor, which
 * will trigger the appropriate GeoView API call.
 *

This blank line is not represented in the list above

Copy link
Member Author

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jolevesq reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Alex-NRCan, DamonU2, and MatthewMuehlhauserNRCan).


CONTRIBUTING.md line 90 at r4 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

Uptional > Optional

Done.


.github/copilot-instructions.md line 239 at r4 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

This blank line is not represented in the list above

Done.

Copy link
Member

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamonU2 reviewed 5 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Alex-NRCan and MatthewMuehlhauserNRCan).

Copy link
Member

@Alex-NRCan Alex-NRCan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-NRCan reviewed 13 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on MatthewMuehlhauserNRCan).

@jolevesq jolevesq merged commit 777e2a1 into Canadian-Geospatial-Platform:develop Feb 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants