Fix external DB connectivity by using USE_EXTERNAL_DB variable

[sanjay-thiyagarajan]

No description provided.

[github-actions]

🐳 The image based on 7bdfd619 commit has been built with 1.39.11-20250601-498 tag as ghcr.io/canastawiki/canasta:1.39.11-20250601-498

[yaronkoren]

This looks fine - but could you explain what was going wrong with the old code?

[sanjay-thiyagarajan]

This looks fine - but could you explain what was going wrong with the old code?

It is due to this line - https://github.com/CanastaWiki/Canasta/blob/master/_sources/scripts/run-maintenance-scripts.sh#:~:text=waitdatabase()%20%7B-,%23!%2Fbin%2Fbash%0A%0Asleep%200.02%0Aprintf,scripts.sh%20%3C%3C%3C%3C%3C%5Cn%5Cn%5Cn%22,-Canasta%2F_sources%2Fscripts

[sanjay-thiyagarajan]

-P should be added while testing the connection on a non-standard port

[yaronkoren]

Sorry, I don't understand - what line are you talking about? And where is the "-P" in the code?

[sanjay-thiyagarajan]

Canasta/_sources/scripts/run-maintenance-scripts.sh

Line 43 in bc511c6

mysql=( mysql -h "$WG_DB_SERVER" -u"$WG_DB_USER" -p"$WG_DB_PASSWORD" )

-p is for password and -P is for port. It is not setting -P at all and just keeps the port in the host - hence, the command never gives a positive output for external DB

[yaronkoren]

Okay, thanks, I think I get it. Mostly I just wanted a clear explanation here, for anyone looking at this in the future.