Version 3.0: massive overhaul, with most code moved to CanastaBase repo#503
Version 3.0: massive overhaul, with most code moved to CanastaBase repo#503yaronkoren merged 24 commits intomasterfrom
Conversation
yaronkoren
requested review from
jeffw16,
naresh-kumar-babu,
pastakhov,
sanjay-thiyagarajan and
vedmaka
yaronkoren
changed the title
The main functionality (and main source of bugs, presumably) is now in CanastaBase - while the set of extensions and skins is mostly determined by what's in "Recommended revisions". So there's no real need for any of these issue templates here - and they may just confuse users.
naresh-kumar-babu
left a comment
naresh-kumar-babu
left a comment
There was a problem hiding this comment.
Looks good and everything works on testing.
|
@naresh-kumar-babu What’s up with the re-approval? It doesn’t override my request for changes. Please don’t try to undermine my requests for changes/clarification. I made them blocking for a reason. |
|
I asked him to re-approve, because I didn't realize at the time that you had blocked this patch. |
|
I have no further concerns with the PR. Once these concerns are addressed, I'll approve this PR. Well done team! Bravo and hats off to you! |
It's no longer "Recommended revisions". The old URL still works, but it's better to be fully correct.
|
@jeffw16 - well, now that the release has been delayed for this long, it's probably to just wait until Monday - I try to avoid doing releases on Fridays. So, I suppose you have three days now to add that version-declaration change into the next Canasta release, if you're into that sort of thing! |
|
🐳 The image based on c5d2444b commit has been built with |
4 participants
No description provided.