Conversation
|
🐳 The image based on 7dbb17dc commit has been built with |
DanielWTQ
reviewed
Sep 18, 2025
Member
DanielWTQ
left a comment
DanielWTQ
left a comment
There was a problem hiding this comment.
2 minor suggestions but this has already been merged, just noting for the record
| } | ||
| }; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
we should unset( $tmpProxy ); to avoid the global variable polluting things
| ], | ||
| 'proxy' => $server | ||
| ]; | ||
| MediaWiki\MediaWikiServices::getInstance()->getHttpRequestFactory() |
Member
There was a problem hiding this comment.
I'd suggest using the fully qualified \MediaWiki\...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new ENV variable
MW_PROXY_SERVERSthat allows setting front-running caching proxies:MW_PROXY_SERVERS=varnishif you're running varnish on the same stack$wgUseCdn, populates$wgCdnServers, enables$wgUsePrivateIPsto make the wiki sendPURGErequests to the proxy serversLinksUpdateCompletehook that re-warms the proxy cache once the PURGE was performed to avoid cold hits