Merged
Conversation
1.3.0 had the hook but 1.3.1 includes the version bump and release notes. This fixes the Canasta version not appearing on Special:Version.
The 3.3.1 release notes claimed CanastaBase 1.3.1 but the Dockerfile still pinned 1.2.1. This release actually updates the base image.
Member
|
Should v. 3.3.0 simply be removed from the release notes, since there was apparently no real change in that version? |
Contributor
Author
|
I think it's better to leave it there so we don't wonder in the future if we forgot to put something there. We'll just look at think, "Oh, that was silly" not "Oh, man, what did we forget to document?" |
Member
|
Okay, but - CanastaBase was not actually updated to 1.3.0, if I understand it correctly. |
Contributor
Author
|
Oh, true. We don't even have a 3.3.0 tagged release. Yes, I will remove that row. |
Removed entry for version 3.3.0 from release notes.
Contributor
Author
|
Done |
|
🐳 The image based on df6900e1 commit has been built with |
yaronkoren
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canasta-base:1.2.1tocanasta-base:1.3.1Picks up:
The Canasta-side changes (VERSION file copy) were already merged in #598, but the base image wasn't bumped, so the SoftwareInfo hook was missing and the version didn't appear on Special:Version.
Fixes #601