Fix all hadolint warnings in Dockerfile#87
Merged
yaronkoren merged 3 commits intomasterfrom Feb 13, 2026
Merged
Conversation
- Add SHELL pipefail before piped RUN commands (DL4006) - Add --no-install-recommends to apt-get/aptitude install (DL3015) - Replace apt with apt-get for postfix install (DL3027) - Clean up apt lists after postfix install (DL3009) - Double-quote all variable references in RUN commands (SC2086) - Add cd || exit for safety (SC2164) - Suppress DL3008 (pin versions) — impractical for Debian system packages - Suppress DL3003 (use WORKDIR) — cd is used within multi-command chains
Move explanatory comments to separate lines above hadolint ignore directives (inline -- comments are not supported by hadolint). Use --without-recommends instead of --no-install-recommends for aptitude.
|
🐳 The image based on 7f47b3f8 commit has been built with |
yaronkoren
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHELLpipefail directive before piped RUN commands--no-install-recommendsto apt-get/aptitude installaptwithapt-getfor postfix installcd || exitfor safetycdis used within multi-command&&chainsCloses #86
Test plan
hadolint Dockerfileproduces no output