Fix log directory permissions in run-all.sh non-mountpoint branch#90
Merged
yaronkoren merged 1 commit intomasterfrom Feb 13, 2026
Merged
Fix log directory permissions in run-all.sh non-mountpoint branch#90yaronkoren merged 1 commit intomasterfrom
yaronkoren merged 1 commit intomasterfrom
Conversation
The non-mountpoint branch was missing chgrp and used o=rwX (other only) instead of g=rwX (group). This left /var/log/mediawiki owned by root:root with no group write permission, causing "Permission denied" errors when www-data tried to write log files (e.g. mwjobrunner_log_*). The bug was latent since #420 but masked by the synchronous make_dir_writable call that followed. It became visible after #81 backgrounded that call. Fixes #89
|
🐳 The image based on c077fb39 commit has been built with |
yaronkoren
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chgrp -R "$WWW_GROUP"to the non-mountpoint branch for the MediaWiki log directorychmod -R o=rwX(other only) tochmod -R g=rwX(group), matching the pattern used by every other log permission block in the fileProblem
When
/var/log/mediawikiis not a bind mount, the directory is created asroot:rootwith no group write permission. Thewww-datauser then gets "Permission denied" when writing log files (e.g.,mwjobrunner_log_*).The bug was latent since #420 but masked by the synchronous
make_dir_writablecall that followed. It became visible after #81 backgrounded that call.Fixes #89
Test plan
/var/log/mediawiki/var/log/mediawikihas groupwww-dataand group write permission