Replace automatic SMW rebuildData with user notification#92
Merged
yaronkoren merged 1 commit intomasterfrom Feb 13, 2026
Merged
Replace automatic SMW rebuildData with user notification#92yaronkoren merged 1 commit intomasterfrom
yaronkoren merged 1 commit intomasterfrom
Conversation
Instead of running rebuildData.php automatically on container startup (which can block for a very long time on large wikis), detect newly set up SMW wikis and print a message telling the user to run it manually. This gives users control over rebuildData options (e.g. --startidfile, page ranges) which is important for large wikis where the rebuild needs to be done in segments. Fixes #91
82123ef to
d96ebb1
Compare
|
🐳 The image based on d96ebb14 commit has been built with |
This was referenced Feb 13, 2026
yaronkoren
approved these changes
Feb 13, 2026
Member
yaronkoren
left a comment
There was a problem hiding this comment.
That final note to the user might not be fully correct, but this looks good enough for now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rebuildData.phpcall from container startupProblem
rebuildData.phpran synchronously during startup, blocking the web server, log permissions, and php-fpm from starting. On large wikis this could take hours, leaving the site completely down. Additionally, large wikis need control over rebuild options (--startidfile, page ranges, etc.) that can't be automated.Approach
Instead of running
rebuildData.phpautomatically, detect when SMW was newly set up (by comparing.smw.jsonbefore and afterrun_autoupdate) and print a message:A CLI command (
canasta maintenance smw-rebuild) will be added in a follow-up PR.Fixes #91
Test plan
docker compose logssetupStore.phpviaupdate.phphooks) but data is not populated until the user runsrebuildData.phpmanually