Throw a warning if we find an existing runtime env.txt instead of an exception#11
Open
semateos wants to merge 2 commits intoCandyCoded:mainfrom
Open
Throw a warning if we find an existing runtime env.txt instead of an exception#11semateos wants to merge 2 commits intoCandyCoded:mainfrom
semateos wants to merge 2 commits intoCandyCoded:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a suggestion for how to handle that case instead of throwing the exception. It does mean you might make a build with out of date env values. But odds are that the file is there because you just tried to make a build with those values and it failed, so using the file you had attempted to use seems fine.