Skip to content

Add OAuth2 support to IbisTrinoConnection #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add OAuth2 support to IbisTrinoConnection #1298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c3ffe
Add OAuth2 support to IbisTrinoConnection
nakulgan Feb 13, 2025
c4f02f2
Add unit tests and integration tests for OAuth2 authentication in Tri…
nakulgan Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions wren-ui/src/apollo/server/adaptors/ibisAdaptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export interface IbisTrinoConnectionInfo {
schema: string;
user: string;
password: string;
auth?: OAuth2Authentication;
}

export interface IbisSnowflakeConnectionInfo {
Expand All @@ -63,6 +64,12 @@ export interface IbisSnowflakeConnectionInfo {
schema: string;
}

export interface OAuth2Authentication {
clientId: string;
clientSecret: string;
tokenUrl: string;
}

export type IbisConnectionInfo =
| UrlBasedConnectionInfo
| HostBasedConnectionInfo
Expand Down
36 changes: 36 additions & 0 deletions wren-ui/src/components/pages/setup/dataSources/TrinoProperties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,42 @@ export default function TrinoProperties({ mode }: Props) {
>
<Input.Password placeholder="Input password" />
</Form.Item>
<Form.Item
label="OAuth2 Client ID"
name="clientId"
rules={[
{
required: false,
message: ERROR_TEXTS.CONNECTION.CLIENT_ID.REQUIRED,
},
]}
>
<Input placeholder="OAuth2 Client ID" />
</Form.Item>
<Form.Item
label="OAuth2 Client Secret"
name="clientSecret"
rules={[
{
required: false,
message: ERROR_TEXTS.CONNECTION.CLIENT_SECRET.REQUIRED,
},
]}
>
<Input.Password placeholder="OAuth2 Client Secret" />
</Form.Item>
<Form.Item
label="OAuth2 Token URL"
name="tokenUrl"
rules={[
{
required: false,
message: ERROR_TEXTS.CONNECTION.TOKEN_URL.REQUIRED,
},
]}
>
<Input placeholder="OAuth2 Token URL" />
</Form.Item>
<Form.Item label="Use SSL" name="ssl" valuePropName="checked">
<Switch />
</Form.Item>
Expand Down