Skip to content

Backported bug fixes for 3.2 branch#2092

Draft
speth wants to merge 24 commits intoCantera:3.2from
speth:backports-3.2
Draft

Backported bug fixes for 3.2 branch#2092
speth wants to merge 24 commits intoCantera:3.2from
speth:backports-3.2

Conversation

@speth
Copy link
Member

@speth speth commented Feb 20, 2026

Changes proposed in this pull request

This is a collection of bug fixes from the main branch, cherry-picked onto the 3.2 branch in anticipation of making a patch release (3.2.1).

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • [ ] AI Statement is included N/A
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 70.73171% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.39%. Comparing base (0f16842) to head (881cd7f).

Files with missing lines Patch % Lines
interfaces/cython/cantera/jacobians.pyx 23.07% 10 Missing ⚠️
interfaces/cython/cantera/ck2yaml.py 82.69% 8 Missing and 1 partial ⚠️
interfaces/cython/cantera/_types.py 60.00% 2 Missing ⚠️
src/kinetics/InterfaceKinetics.cpp 0.00% 2 Missing ⚠️
interfaces/cython/cantera/ctml2yaml.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              3.2    #2092      +/-   ##
==========================================
+ Coverage   76.38%   76.39%   +0.01%     
==========================================
  Files         463      463              
  Lines       55034    55049      +15     
  Branches     9317     9319       +2     
==========================================
+ Hits        42037    42054      +17     
  Misses       9865     9865              
+ Partials     3132     3130       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@speth speth force-pushed the backports-3.2 branch 2 times, most recently from aeecb86 to 13c849c Compare February 21, 2026 00:10
@bryanwweber
Copy link
Member

One thing we'll need to check before doing a big fix release is that tags build the wheels using the main branch of the pypi-packages repo, so if there are and incompatible changes over there, we just need to watch out

speth and others added 20 commits February 20, 2026 22:27
Repeated calls to 'locale' in the OpenAI Codex sandbox are very slow.
Making this static resolves the problem, and also modestly speeds up
input parsing in general.
…antera#2086)

This allows running scons in sandboxes like those used by OpenAI Codex.
…ra#2056)

ParamSpec is available in Python proper starting with 3.10
)

Using shared_ptr route ensures ThermoPhase objects used by MultiPhase
are still present when the MultiPhase destructor runs.
@speth
Copy link
Member Author

speth commented Feb 21, 2026

One thing we'll need to check before doing a big fix release is that tags build the wheels using the main branch of the pypi-packages repo, so if there are and incompatible changes over there, we just need to watch out

Yeah, I had an inkling that this might be a challenge. It's been a while since we did a true patch release after letting the main branch diverge.

@bryanwweber
Copy link
Member

Yeah, I had an inkling that this might be a challenge. It's been a while since we did a true patch release after letting the main branch diverge.

I think as of today, there aren't any breaking changes on the main branch in the pypi-packages repo. The only breaking change in a PR currently is removing support for Intel macOS. The easiest thing to do is probably fork a 3.2 branch from main right now in pypi-packages and backport the relevant updates from the open PR. Then, we can just cancel the automated build-on-tag that gets triggered when we tag 3.2.1 and manually trigger a build from the pypi-packages 3.2 branch pointing at the cantera/Cantera 3.2.1 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants