chore: sync upstream PR #7803 - fix(android): Subsequent build crash with missing version data#23
chore: sync upstream PR #7803 - fix(android): Subsequent build crash with missing version data#23
Conversation
📝 WalkthroughWalkthroughA null-safety guard was added in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
679b7c3 to
9b02d96
Compare
9b02d96 to
83cf40d
Compare
There was a problem hiding this comment.
Pull request overview
Syncs upstream Capacitor fix for an Android crash on subsequent builds when PackageInfo.versionName is missing (null).
Changes:
- Guard assignment of
versionNameto avoid null propagation that can lead to a crash in version comparisons. - Preserve existing stored binary version comparison behavior while preventing NPEs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Upstream PR Sync
This PR syncs changes from an external contributor's PR on the official Capacitor repository.
Original PR
Automation
Synced from upstream by Capacitor+ Bot
Summary by CodeRabbit