Skip to content

Conversation

oscartbeaumont
Copy link
Member

@oscartbeaumont oscartbeaumont commented Sep 23, 2025

This will possibly allow sharing code with the Loom importer and make for a more reliable upload process.

TODO:

  • Disable progress reporting on legacyCapUpload. We will only enable it for the Effect rewrite in capUpload.
  • Why is instant or studio mode progress reporting not working?
  • Reset current DB state once merged

Effect rewrite:

  • Set thumbnail locally using blob
  • Upload thumbnail at same time as video
  • Pipe converter into video upload

Testing:

  • Does the update progress report across clients?
  • Can we make the thumbnail show up earlier and less glitchy?
  • Testing CapUploadButton

Copy link
Contributor

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cap-web Ready Ready Preview Comment Sep 24, 2025 7:48am

Copy link
Contributor

coderabbitai bot commented Sep 23, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch effect-upload-button

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oscartbeaumont oscartbeaumont force-pushed the effect-upload-button branch 3 times, most recently from 0c40e28 to 22ebbe2 Compare September 24, 2025 07:23
@oscartbeaumont oscartbeaumont linked an issue Sep 24, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effectify upload progress system in web
1 participant