Skip to content

run clippy as part of rust cache #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 3 commits into from
Nov 4, 2025
Merged

run clippy as part of rust cache #1345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96143c1
run clippy as part of rust cache
Brendonovich Nov 4, 2025
f03a31a
don't bother building desktop if no desktop changes
Brendonovich Nov 4, 2025
788c5be
run clippy on windows too
Brendonovich Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,23 +98,29 @@ jobs:
runs-on: macos-latest
needs: changes
if: needs.changes.outputs.rust == 'true'
strategy:
fail-fast: false
matrix:
settings:
- target: aarch64-apple-darwin
runner: macos-latest
- target: x86_64-pc-windows-msvc
runner: windows-latest
permissions:
contents: read
env:
target: aarch64-apple-darwin
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Rust setup
uses: dtolnay/rust-toolchain@stable
with:
targets: ${{ env.target }}
targets: ${{ matrix.settings.target }}
components: clippy

- uses: ./.github/actions/setup-rust-cache
with:
target: ${{ env.target }}
target: ${{ matrix.settings.target }}

- name: Create .env file in root
run: |
Expand Down Expand Up @@ -157,7 +163,7 @@ jobs:
build-desktop:
name: Build Desktop
needs: changes
if: needs.changes.outputs.rust == 'true' || needs.changes.outputs.desktop == 'true'
if: needs.changes.outputs.desktop == 'true'
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -270,3 +276,9 @@ jobs:

- name: Build release
run: cargo check --all --release

- name: Run Clippy
if: ${{ matrix.settings.target == 'aarch64-apple-darwin' || matrix.settings.target == 'x86_64-pc-windows-msvc' }}
uses: actions-rs-plus/clippy-check@v2
with:
args: --workspace --all-features --locked
Loading