-
Notifications
You must be signed in to change notification settings - Fork 743
Address resource loading with GCS and restore domain signup restrictions #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mogita
wants to merge
16
commits into
CapSoftware:main
Choose a base branch
from
mogita:signed-url-by-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4a2801e
feat: generated signed url for assets by default
mogita a5ebe9b
Merge branch 'main' into signed-url-by-default
mogita 0c95141
chore: add generated migration files
mogita e4be33b
Merge branch 'main' into signed-url-by-default
mogita 3fe3644
build: setup required env vars for building
mogita 925d33a
chore: remove non-existent migration record
mogita 574a481
Merge branch 'main' into signed-url-by-default
mogita d43d9c1
fix: remove NEXT_PUBLIC_IS_CAP from the image
mogita 95a5a60
feat: add back the allowed domain restriction on signup
mogita 322702f
feat: load screenshot and thumbnails by signed urls
mogita 242780d
Merge branch 'main' into signed-url-by-default
mogita 0d092c1
Merge branch 'main' into signed-url-by-default
mogita a9b760a
chore: restore database files
mogita d40d3f7
feat: block un-authenticated access to playlist url
mogita 56caf49
feat: query bucket by video id
mogita 8151df0
format: fix biome issue
mogita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Don’t write secrets to .env and avoid baking them into images; use GitHub Secrets (and BuildKit secrets) instead.
${{ secrets.* }}
(masked) and preferably BuildKitsecrets:
with matching Dockerfile mounts.Minimal safer change (no Dockerfile edits), move secrets from
.env
to masked build-args and stop writing them to.env
:And mask build-args with repo/environment secrets:
If you can adjust the Dockerfile, prefer BuildKit secrets:
Note: Checkov flagged basic auth in lines 42–43; changes above address it.
I can send a Dockerfile patch using
RUN --mount=type=secret,id=...
if you want.Also applies to: 72-83
🧰 Tools
🪛 Checkov (3.2.334)
[MEDIUM] 42-43: Basic Auth Credentials
(CKV_SECRET_4)