Skip to content

Feat/dark theme#23

Merged
Samu-Kiss merged 7 commits intomainfrom
feat/dark-theme
Jul 23, 2025
Merged

Feat/dark theme#23
Samu-Kiss merged 7 commits intomainfrom
feat/dark-theme

Conversation

@Achalogy
Copy link
Member

@Achalogy Achalogy commented Jul 16, 2025

No description provided.

adrianrrruiz
adrianrrruiz previously approved these changes Jul 17, 2025
View reviewed changes
@adrianrrruiz
Copy link
Contributor

adrianrrruiz commented Jul 17, 2025

@Samu-Kiss Revisar los colores y el nuevo diseño del dark mode

@adrianrrruiz adrianrrruiz requested a review from Samu-Kiss July 17, 2025 01:25
@Achalogy Achalogy dismissed adrianrrruiz’s stale review July 17, 2025 01:29

The merge-base changed after approval.

@adrianrrruiz adrianrrruiz linked an issue Jul 17, 2025 that may be closed by this pull request
Diseño del dark mode #24
Closed
@Samu-Kiss
Copy link
Contributor

Samu-Kiss commented Jul 22, 2025

image Los links del nav ahora están descentrados

@Samu-Kiss
Copy link
Contributor

Samu-Kiss commented Jul 22, 2025

image

Cambiar color en especial del rol por el azul niebla y el color de fondo por le azul noche

image

@Samu-Kiss
Copy link
Contributor

Samu-Kiss commented Jul 22, 2025

image

no hay contraste en el el texto de "somos un grupo..."

Samu-Kiss
Samu-Kiss requested changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@Samu-Kiss Samu-Kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y ya de recomendación final, revisa los colores y sus usos según el manual de marca
https://livejaverianaedu-my.sharepoint.com/:b:/g/personal/sa_pico_javeriana_edu_co/EQi3JZmB21FNodu2_jLA_bIBgozLSoxrGs85GqypimiYHg?e=JAJ9Ev

Achalogy added 2 commits July 21, 2025 20:06
@Achalogy
fix(ui): adjust nav link alignment and improve text contrast #23
be43d2b 
- Re-centered navigation links
- Updated role highlight color
- Changed background color
- Improved contrast
@Achalogy
Merge branch 'feat/dark-theme' of github.com:CapituloJaverianoACM/ACM…
4755428 
…-Web-Page-UI into feat/dark-theme
@Achalogy Achalogy requested a review from Samu-Kiss July 22, 2025 01:06
Samu-Kiss
Samu-Kiss previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@Samu-Kiss Samu-Kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro jajaj que eficiencia, todo bien, solo cambia el color de fondo del modal de miembros de vuelta al que estaba antes (perdon jajaj, en mi mente se veía distinto)

@Achalogy Achalogy dismissed Samu-Kiss’s stale review July 22, 2025 01:47

The merge-base changed after approval.

@TalkySafe143
Copy link
Member

TalkySafe143 commented Jul 22, 2025

@Achalogy toca que resuelva el merge :P

@Achalogy Achalogy requested a review from Samu-Kiss July 23, 2025 02:46
Samu-Kiss
Samu-Kiss approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@Samu-Kiss Samu-Kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Samu-Kiss Samu-Kiss merged commit 8a55464 into main Jul 23, 2025
1 check passed
@TalkySafe143 TalkySafe143 deleted the feat/dark-theme branch July 26, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Samu-Kiss Samu-Kiss Samu-Kiss approved these changes

@adrianrrruiz adrianrrruiz adrianrrruiz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Diseño del dark mode

4 participants

@Achalogy @adrianrrruiz @Samu-Kiss @TalkySafe143