Fix generic "timeout" message not working in non-blocking mode? #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes all non blocking examples
Collaborator
|
Hi, good that you did not merge this change. As far as I know, timeouts only occur when the socket is blocking. Other than that I'd rather not introduce multiple returns in a function when not strictly needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is what was meant here, can you confirm? @vwout
When a socket is non-blocking, you might get these timeout ish errors which result in a single "timeout" message for the developer's convince.
But the current logic seem to check if the socket is blocking, rather than non-blocking.
This PR fixes all the non blocking examples on my macbook air at least. But can we get timeout errors when the socket is blocking as well?