Skip to content

Conversation

daerogami
Copy link

@daerogami daerogami commented Nov 1, 2024

From issue #2:

Also, is this a stand-alone script or should this be in my godot project's scripts folder? because my project is inside a folder named src, so unless there is a way to tell the Apply version to export information step to change its working directory, there are file path assumptions that won't work with my project being inside a folder instead of the root of the repo.

@daerogami daerogami mentioned this pull request Nov 1, 2024
@jonjondev jonjondev self-requested a review November 2, 2024 22:36
@jonjondev
Copy link
Member

jonjondev commented Nov 2, 2024

I would double check whether leaving the default value as blank will provide the same functionality as .\, but otherwise the looks fine to merge. Please update the documentation to include the new input parameter for build-godot and we can proceed from there.

Note that you will need to rebase on top of latest changes on main - please do not add a merge-commit.

@daerogami
Copy link
Author

Thanks Jon! Will take a look at this between today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants