Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

update httpretty#21

Open
caleb15 wants to merge 1 commit intoCaptricity:masterfrom
caleb15:patch-1
Open

update httpretty#21
caleb15 wants to merge 1 commit intoCaptricity:masterfrom
caleb15:patch-1

Conversation

@caleb15
Copy link

@caleb15 caleb15 commented Apr 1, 2020

See #20

This should make mocurly python 3.7 compatible.

Note that this passes unit tests on our side but I haven't ran the unit tests for this project yet. Hopefully the CI will do that for me?

@caleb15
Copy link
Author

caleb15 commented Apr 1, 2020

It doesn't look like there's any CI to automatically run unit tests, darn. Guess I'll do it manually.

@caleb15
Copy link
Author

caleb15 commented Apr 23, 2020

Some unit test errors due to new httpretty w/ python 3.6 (probably 3.7 too) unfortunately:

======================================================================
ERROR: test_timeout_successful_post (tests.test_core.TestCore)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/caleb/Documents/misc/mocurly/tests/test_core.py", line 129, in test_timeout_successful_post
    self.assertRaises(ssl.SSLError, new_transaction.save)
  File "/usr/lib/python3.6/unittest/case.py", line 733, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/usr/lib/python3.6/unittest/case.py", line 178, in handle
    callable_obj(*args, **kwargs)
  File "/home/caleb/.local/lib/python3.6/site-packages/recurly/resource.py", line 650, in save
    return self._create()
  File "/home/caleb/.local/lib/python3.6/site-packages/recurly/resource.py", line 657, in _create
    return self.post(url)
  File "/home/caleb/.local/lib/python3.6/site-packages/recurly/resource.py", line 673, in post
    response = self.http_request(url, 'POST', body or self, {'Content-Type': 'application/xml; charset=utf-8'})
  File "/home/caleb/.local/lib/python3.6/site-packages/recurly/resource.py", line 293, in http_request
    resp = connection.getresponse()
  File "/usr/lib/python3.6/http/client.py", line 1356, in getresponse
    response.begin()
  File "/usr/lib/python3.6/http/client.py", line 307, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.6/http/client.py", line 276, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant