Keep track of perpetual mana cost changes for display

[TrevorHayes]

Currently perpetual changes to P/T are reflected in hand but mana cost changes are not. This change tracks perpetual mana cost reductions so they can be displayed in hand (and other zones).

Normally this just means reducing (or increasing) the generic mana cost value, but for spells with X in the cost decreasing the cost contributes to "X" so for those spells I have added the generic reduction as an additional mana symbol after the regular mana costs but with a yellow highlight. For example, a Fireball spell reduced by 2 mana would display as XR2 where the 2 is outlined in yellow. This should be fairly intuitive since the player sees it appear when they reduce the cost. I experimented with displaying it as XR-2 (which is what it says in the card text box) but that takes up another symbol's worth of room and looks funny. I tried adding "-" to the generic cost symbol but that was hard to read.

I have tested decreasing costs and increasing costs with regular spells, spells with both X and regular generic costs like X2B (Ingenious Mastery), spells that set the mana cost to a specific value (thought partition; this already worked but I didn't break it), and spells that have changed zones before and after cost reductions.

[tehdiplomat]

I Don't have any major problems with this, but i think it should still be an option for people to disable if they don't want it:

[TrevorHayes]

I Don't have any major problems with this, but i think it should still be an option for people to disable if they don't want it:

Ah, I like that as a place to put it rather than the general settings. I'll have to track down the other perpetual changes that are already displayed and change that code as well, I suppose.

[TrevorHayes]

I Don't have any major problems with this, but i think it should still be an option for people to disable if they don't want it:

I have added the suggested menu option as "Perpetual Changes to Mana Cost" and verified that it works. However, I have not added translations to the localization files as I'm not confident Google Translate would use the correct terms. What's usually done for localization? I don't know how much this matters; I notice lots of labels that don't have localization and fall back to the English strings.