AttackRequirement: use StaticAbility instead of Keywords#9747
Merged
AttackRequirement: use StaticAbility instead of Keywords#9747
Conversation
tool4ever
reviewed
Feb 14, 2026
forge-game/src/main/java/forge/game/staticability/StaticAbilityAttackRequirement.java
Outdated
Show resolved
Hide resolved
Hanmac
force-pushed
the
staticAttackRequirement
branch
from
2b3d908 to
132682f
Compare
Contributor
Author
|
@tool4ever |
Contributor
|
maybe if it'll look cleaner / help performance? |
Contributor
Author
Maybe, I think I need to refactor this one later too 🤔 |
tool4ever
reviewed
Feb 14, 2026
Hanmac
force-pushed
the
staticAttackRequirement
branch
from
132682f to
130cb5c
Compare
tool4ever
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3593
This replaces the Magnet Logic and the other two instances with StaticAbilities
(War Toll might be changed later for SharedTurn stuff)