Skip to content

BAC-255: Disable nightly #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marcin-Radecki merged 2 commits into from
Nov 13, 2025
Merged

BAC-255: Disable nightly #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8503562
Disable nightly
Marcin-Radecki Nov 13, 2025
27d8ddb
Linter
Marcin-Radecki Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/testnet-nightly-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# This workflow is out-to-date. It won't work as it is now, due to the fact Base Sepolia testnet
# has a specific behaviour resulting in errors like "replacement transaction underpriced" or "nonce too low:".
# current workaround was to sleep, but it was removed in
# https://github.com/Cardinal-Cryptography/blanksquare-monorepo/commit/72536953ee7d324b4a776c0726ae035bace88655
Comment on lines +1 to +4
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Remove trailing whitespace to pass linter checks.

Here, in the shadow of the comment block, we observe a most peculiar phenomenon: invisible spaces at the line's end. The yamllint creature, ever vigilant, has detected these imperceptible interlopers lurking at lines 1 and 3. They must be expunged posthaste.

Apply this diff to eliminate the trailing spaces:

-# This workflow is out-to-date. It won't work as it is now, due to the fact Base Sepolia testnet 
-# has a specific behaviour resulting in errors like "replacement transaction underpriced" or "nonce too low:".
-# current workaround was to sleep, but it was removed in 
-# https://github.com/Cardinal-Cryptography/blanksquare-monorepo/commit/72536953ee7d324b4a776c0726ae035bace88655
+# This workflow is out-to-date. It won't work as it is now, due to the fact Base Sepolia testnet
+# has a specific behaviour resulting in errors like "replacement transaction underpriced" or "nonce too low:".
+# current workaround was to sleep, but it was removed in
+# https://github.com/Cardinal-Cryptography/blanksquare-monorepo/commit/72536953ee7d324b4a776c0726ae035bace88655
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# This workflow is out-to-date. It won't work as it is now, due to the fact Base Sepolia testnet
# has a specific behaviour resulting in errors like "replacement transaction underpriced" or "nonce too low:".
# current workaround was to sleep, but it was removed in
# https://github.com/Cardinal-Cryptography/blanksquare-monorepo/commit/72536953ee7d324b4a776c0726ae035bace88655
# This workflow is out-to-date. It won't work as it is now, due to the fact Base Sepolia testnet
# has a specific behaviour resulting in errors like "replacement transaction underpriced" or "nonce too low:".
# current workaround was to sleep, but it was removed in
# https://github.com/Cardinal-Cryptography/blanksquare-monorepo/commit/72536953ee7d324b4a776c0726ae035bace88655
🧰 Tools
🪛 GitHub Actions: GH Action YAML linter

[error] 1-1: yamllint: trailing spaces detected at line 1 (trailing-spaces).

[error] 3-3: yamllint: trailing spaces detected at line 3 (trailing-spaces).

🤖 Prompt for AI Agents 
.github/workflows/testnet-nightly-e2e.yml lines 1-4: remove trailing whitespace
at the ends of lines 1 and 3 which is causing yamllint failures; edit the file
to delete the invisible spaces at those line ends (ensure no other trailing
spaces remain in the file) and save so the linter passes.

---
name: Nightly E2E tests run on testnet

on:
schedule:
- cron: "00 23 * * *"
workflow_dispatch:

concurrency:
Expand Down
Loading