Conversation
…try/ground-station into new-packet-format
* updated some naming to be clearer for the new non-versioned spec * add some updates for correctness * removed the old spec as it won't be useful anymore with no versioning
* used a more dynamic approach for block parsing so we could get access to more useful data elsewhere
* combined the newer method with dataclasses to get benefits of both
* this new method will be slower, but should make it easier to understand what's happening. Blocks get parsed, blocks get converted to a big dict, big dict gets sent. Where measurements get put in the final product is up to the Blocks and very explicit in code * also gives a good opportunity to do unit conversions in a easy to see place
* renamed the telemetry buffer class to reflect what it actually does * removed the decoder, blocks are now directly responsible for deciding where their measurements end up
linguini1
reviewed
Apr 6, 2025
| def test_metres_to_feet() -> None: | ||
| """Test that metres are properly converted to feet.""" | ||
| assert conv.metres_to_feet(5.0) == pytest.approx(16.4) # type: ignore | ||
| assert metres_to_feet(5.0) == pytest.approx(16.4) # type: ignore |
Collaborator
There was a problem hiding this comment.
Did not know about this approx helper, gonna start using that from now on!
linguini1
previously approved these changes
Apr 6, 2025
Collaborator
|
I guess we should fix the CI tests later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109
Closes #110
ok there's quite a few commitsThis PR implements and migrates the ground-station packet spec over to version 2 specified here. It also simplifies the telemetry buffer system of ye olden days and deprecates the json file which shall not be named. This PR adds a script
logfile_converter.pyto convert raw output from Josh into a replayable mission file for testing.Edit: Moved all v1 missions into archive folder