Feat/rewrite scaffold recordings#130
Conversation
|
FYI, I'm allowed to merge which shouldn't be allowed for security. 
|
Bah that's fine I didn't add branch protection on this rewrite branch, I'm going to throw it into main soon anyways |
There was a problem hiding this comment.
You shouldn't import by path, look at the readme installation all the way to the bottom, you may have skipped the pip install -e . step
There was a problem hiding this comment.
Fix this pattern everywhere in your files plz
| for client_id in disconnected: | ||
| connected_clients.pop(client_id, None) | ||
|
|
||
| recorder.stop() |
There was a problem hiding this comment.
would this recorder.stop() ever fire?
There was a problem hiding this comment.
Seems like the loop from the packets doesn't end. I think its good to have just in case anything abnormal from the packet function.
| @app.post("/record_stop") | ||
| async def record_stop(x_client_id: str = Header(alias="X-Client-ID")): | ||
|
|
||
| recorder.stop() |
There was a problem hiding this comment.
Not sure about this one but maybe stopping the recording should also just close the mission, what do you think
There was a problem hiding this comment.
Maybe can call the stop function inside of the close mission function, but not completely take away the stop function?
2 participants
No description provided.