Merge Sync rework branch #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CarlosDerSeher <[email protected]>
fix CarlosDerSeher#148 Signed-off-by: CarlosDerSeher <[email protected]>
Signed-off-by: CarlosDerSeher <[email protected]>
Signed-off-by: CarlosDerSeher <[email protected]>
* Implement Kalmann filter for latency * Fix sdkconfig for esp32s3 * Reduce filter full threshold * Implement feedback. Make sure static variables are initialized.
calling netconn API from 2 task isn't safe so set a timeout on netconn_receive and do sending those time messages directly from http_task - ensure all resources used by player_task are created before the task is created - do not reset latency buffer in start_player() Signed-off-by: CarlosDerSeher <[email protected]>
Owner
|
Seems to behave as expected with mdns enabled |
Owner
|
I found just one thing. Clients start up very quiet and I always need to move the volume up and down in the android app to get it to the correct setting. |
Contributor
Author
|
Is this new or does it also happen with develop or sync_rework branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me it is working, but someone should test with mdns. I needed to resolve some conflicts and can't test here.
@anabolyc Could you please give this a quick try, just to make sure I didn't mess up your UI improvements?
There is a lot of new commented code in main.c, should I remove that?