chore(ci): Fix build and release scripts#77
Merged
donmccurdy merged 4 commits intomainfrom Apr 1, 2025
Merged
Conversation
donmccurdy
changed the title
This was referenced Mar 31, 2025
Merged
jmgaya
approved these changes
Apr 1, 2025
| @@ -64,7 +71,7 @@ export class FormulaWidgetComponent { | |||
| ) | |||
| .then((response) => { | |||
There was a problem hiding this comment.
Does it make sense to type the response instead?
Author
There was a problem hiding this comment.
The response type is known to be FormulaResponse, unfortunately we need the cast because the officially the response type can be null. I'm not sure it should be nullable so I have a TODO to try to change the type in the API client, rather than trying to do special null-handling in the template for now. :)
There was a problem hiding this comment.
Gotcha! Yeah, we should probably be more explicit with the response, otherwise casting it as a consumer feels a bit strange 👍
| @@ -45,7 +49,7 @@ export function FormulaWidget({ | |||
| }), | |||
| ) | |||
| .then((response) => { | |||
There was a problem hiding this comment.
Does it make sense to type the response instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
@carto/api-clientv0.4.9