fix bug where path was crashing http request#1692
Open
dedicatedbroadcastsolutions wants to merge 4 commits intoCasparCG:masterfrom
Open
fix bug where path was crashing http request#1692dedicatedbroadcastsolutions wants to merge 4 commits intoCasparCG:masterfrom
dedicatedbroadcastsolutions wants to merge 4 commits intoCasparCG:masterfrom
Conversation
dedicatedbroadcastsolutions
force-pushed
the
BUG_Fix_url_encoding_for_path
branch
from
224a88d to
c896b31
Compare
dedicatedbroadcastsolutions
added a commit
to dedicatedbroadcastsolutions/server
that referenced
this pull request
Jan 17, 2026
- Add url_encode_path() function to properly encode file paths in URLs - Encode individual path components while preserving path separators - Handle both Windows backslashes and Linux forward slashes - Properly encode spaces and special characters in filenames - Improve HTTP error messages to show actual status codes Fixes CasparCG#1692
- Add url_encode_path() function to handle file paths properly - Encode path components while preserving forward slash separators - Support both Windows backslashes and Unix forward slashes - Update AMCP commands: thumbnail_retrieve, thumbnail_generate, cinf - Improve HTTP error messages with actual status codes - Replace stringstream with direct string operations for better performance - Follow RFC 3986 for URL encoding of unreserved characters Fixes issue where file paths with spaces caused 404 errors in thumbnail retrieval and other media-scanner HTTP requests.
dedicatedbroadcastsolutions
force-pushed
the
BUG_Fix_url_encoding_for_path
branch
from
a469e90 to
0d53f1b
Compare
dedicatedbroadcastsolutions
force-pushed
the
BUG_Fix_url_encoding_for_path
branch
from
b9dddcb to
bed52e5
Compare
Debian package versions don't allow underscores. Update the workflow to replace underscores (along with slashes and spaces) with hyphens when generating the build version from the branch name.
dedicatedbroadcastsolutions
force-pushed
the
BUG_Fix_url_encoding_for_path
branch
2 times, most recently
from
eaec545 to
716915d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rough but successful attempt at fixing url path encoding errors with thumbnail retrieval. Thumbnail retrieval was broken on windows for files with some special characters. This was an AI assisted patch so please review changes closely.