Skip to content

Conversation

@wslany
Copy link
Member

@wslany wslany commented Dec 11, 2025

Fixed bad URLs to point to correct informaton.
Removed buttons and menu entries to obsolete features such as the Scratch converter or Uploading of projects to share.

https://catrobat.atlassian.net/browse/IDE-305

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

On the main Catroid landing page, the main menu (top right) shows these two (or three) menu options, but they are not valid anymore. This just removes access to them. The correpsonding code still remains, and maybe be removable in future releases, e.g., via https://catrobat.atlassian.net/browse/IDE-301
Updated various URLs in Constants.java to point to the correct documentation and legal pages.
Removed upload project functionality from MainMenuFragment.
Removed test for back button behavior after tapping upload button since that buttn does not exist anymore on the main menu fragment.
Removed the uploadProject test method from ProjectOptionsTest since we removed the upload functionality to share.catrob.at
Removed project upload functionality from ProjectOptionsFragment.
Updated URLs for Catrobat documentation and wiki references. Unfortunately the original wiki pages apparently were lost without backup. Some of them may still exist on the internet archive site at https://archive.org/
Removed the onSaveProjectComplete function to streamline project saving process.
Removed unused imports from MainMenuFragment.kt
Removed unused imports from ProjectOptionsFragment.kt
Removed login and logout options from the menu.
@wslany wslany marked this pull request as draft December 12, 2025 14:03
Removed the TextView for project upload options.
Since we do not have remote projects anymore, all projects now are "on device". And there is no Catrobat community at the moment, so we redirect to the Catrobat website.
Since this URL is shown under the Catrobat (formely "Catrobat community") link on the app's landing page and previously led to our notice that the server does not exist anymore.
Since this URL is shown under the Catrobat (formely "Catrobat community") link on the app's landing page and previously led to our notice that the server does not exist anymore.
Since this URL is shown under the Catrobat (formely "Catrobat community") link on the app's landing page and previously led to our notice that the server does not exist anymore.
@wslany wslany changed the title Wslany release preparation fixes IDE-305 Fix URLs and remove obsolete buttons Dec 12, 2025
@wslany wslany marked this pull request as ready for review December 12, 2025 20:32
@wslany wslany marked this pull request as draft December 15, 2025 13:30
@wslany wslany closed this Dec 15, 2025
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
Revert incorrect change to rebased develop branch
@wslany wslany reopened this Dec 15, 2025
@sonarqubecloud
Copy link

@wslany wslany marked this pull request as ready for review December 15, 2025 15:11
@reichli reichli added the Active Member Tickets that are assigned to members that are still currently active label Dec 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses IDE-305 by fixing outdated URLs and removing obsolete features related to project uploads and user authentication. The changes update documentation URLs to point to the new Catrobat documentation site and remove UI elements and code for the Scratch converter, login/logout functionality, and project upload features.

Changes:

  • Updated privacy policy and documentation URLs across multiple flavor variants to point to developer.catrobat.org and catrobat.org/docs/
  • Removed upload project buttons and related UI elements from main menu and project options fragments
  • Hidden login/logout and scratch converter menu items by setting them to invisible
  • Removed test files and test methods related to upload functionality

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
catroid/src/*/java/org/catrobat/catroid/common/FlavoredConstants.java (8 files) Updated PRIVACY_POLICY_URL, BASE_URL_HTTPS, and CATROBAT_HELP_URL to new documentation URLs
catroid/src/main/java/org/catrobat/catroid/common/Constants.java Updated multiple wiki/documentation URLs and license URLs
catroid/src/main/res/values/strings.xml Changed menu labels from "Projects on device" to "Projects" and "Catrobat community" to "Catrobat"
catroid/src/main/res/menu/menu_main_menu.xml Set scratch converter, login, and logout menu items to invisible
catroid/src/main/res/layout/fragment_project_options.xml Removed upload project button from project options layout
catroid/src/main/res/layout/fragment_main_menu.xml Removed upload project floating action button
catroid/src/main/java/org/catrobat/catroid/ui/recyclerview/fragment/MainMenuFragment.kt Removed upload-related imports, click listeners, and handler code
catroid/src/main/java/org/catrobat/catroid/ui/fragment/ProjectOptionsFragment.kt Removed upload-related imports, setup methods, and upload functionality
catroid/src/main/java/org/catrobat/catroid/ui/MainMenuActivity.kt Removed onPrepareOptionsMenu method and login/logout menu handlers
catroid/src/androidTest/.../UploadUnmodifiedExampleProjectTest.kt Deleted entire test file for upload functionality
catroid/src/androidTest/.../ProjectOptionsTest.java Removed uploadProject test method
catroid/src/androidTest/.../MainMenuFragmentTest.kt Removed upload button back navigation test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +140 to +148
public static final String CATROBAT_FORMULA_WIKI_URL = "https://catrobat.org/docs/";
public static final String ABOUT_POCKETCODE_LICENSE_URL = "https://developer.catrobat.org/pages/legal/licenses/";
public static final String WEB_REQUEST_WIKI_URL = "https://catrobat.org/docs/";

public static final String CATROBAT_TERMS_OF_USE_URL = "https://developer.catrobat.org/pages/legal/terms-of-use-and-service/";
public static final String CATROBAT_FUNCTIONS_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_LOGIC_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_SENSORS_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_OBJECT_WIKI_URL = "https://catrobat.org/docs/";
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple specific documentation URLs have been changed to point to the same generic "https://catrobat.org/docs/" URL. The constants CATROBAT_FORMULA_WIKI_URL, CATROBAT_FUNCTIONS_WIKI_URL, CATROBAT_LOGIC_WIKI_URL, CATROBAT_SENSORS_WIKI_URL, and CATROBAT_OBJECT_WIKI_URL previously had distinct paths for specific documentation sections. Now they all point to the same generic documentation page, which could result in users not finding the specific information they need. Consider appending appropriate paths or fragments to distinguish these URLs, or verify that the generic docs page adequately handles navigation to these specific sections.

Suggested change
public static final String CATROBAT_FORMULA_WIKI_URL = "https://catrobat.org/docs/";
public static final String ABOUT_POCKETCODE_LICENSE_URL = "https://developer.catrobat.org/pages/legal/licenses/";
public static final String WEB_REQUEST_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_TERMS_OF_USE_URL = "https://developer.catrobat.org/pages/legal/terms-of-use-and-service/";
public static final String CATROBAT_FUNCTIONS_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_LOGIC_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_SENSORS_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_OBJECT_WIKI_URL = "https://catrobat.org/docs/";
public static final String CATROBAT_FORMULA_WIKI_URL = "https://catrobat.org/docs/#formula";
public static final String ABOUT_POCKETCODE_LICENSE_URL = "https://developer.catrobat.org/pages/legal/licenses/";
public static final String WEB_REQUEST_WIKI_URL = "https://catrobat.org/docs/#web-requests";
public static final String CATROBAT_TERMS_OF_USE_URL = "https://developer.catrobat.org/pages/legal/terms-of-use-and-service/";
public static final String CATROBAT_FUNCTIONS_WIKI_URL = "https://catrobat.org/docs/#functions";
public static final String CATROBAT_LOGIC_WIKI_URL = "https://catrobat.org/docs/#logic";
public static final String CATROBAT_SENSORS_WIKI_URL = "https://catrobat.org/docs/#sensors";
public static final String CATROBAT_OBJECT_WIKI_URL = "https://catrobat.org/docs/#objects";

Copilot uses AI. Check for mistakes.
public final class FlavoredConstants {
// Web:
public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS + "/embroidery/";
public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/";
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BASE_URL_HTTPS constant is being changed from a flavor-specific path to a generic documentation URL. This is a significant semantic change that could break features relying on this constant for flavor-specific navigation. The constant is used in Constants.java for SHARE_PROJECT_URL and CATROBAT_DELETE_ACCOUNT_URL, which might no longer function correctly with this generic docs URL. Consider whether these usages need to be updated or if BASE_URL_HTTPS should retain its original purpose.

Suggested change
public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/";
public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS;

Copilot uses AI. Check for mistakes.
public final class FlavoredConstants {
// Web:
public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS + "/create@school/";
public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/";
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BASE_URL_HTTPS constant is being changed from a flavor-specific path to a generic documentation URL. This is a significant semantic change that could break features relying on this constant for flavor-specific navigation. The constant is used in Constants.java for SHARE_PROJECT_URL and CATROBAT_DELETE_ACCOUNT_URL, which might no longer function correctly with this generic docs URL. Consider whether these usages need to be updated or if BASE_URL_HTTPS should retain its original purpose.

Copilot uses AI. Check for mistakes.
public final class FlavoredConstants {
// Web:
public static final String BASE_URL_HTTPS = MAIN_URL_HTTPS + "/pocketcode/";
public static final String BASE_URL_HTTPS = "https://catrobat.org/docs/";
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BASE_URL_HTTPS constant is being changed from a flavor-specific path to a generic documentation URL. This is a significant semantic change that could break features relying on this constant for flavor-specific navigation. The constant is used in Constants.java for SHARE_PROJECT_URL and CATROBAT_DELETE_ACCOUNT_URL, which might no longer function correctly with this generic docs URL. Consider whether these usages need to be updated or if BASE_URL_HTTPS should retain its original purpose.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants