Limb darkening

[375gnu]

published for testing and getting response.

With atmospheres it looks… weird.

[Askaniy]

Is it just me, or is there a sprite (or something similar) in the center of the star that increases the brightness and causes some colors to overexpose?

[Askaniy]

I also think that atmospheres, as a workaround for the glow effect, should be removed

[375gnu]

Is it just me, or is there a sprite (or something similar) in the center of the star that increases the brightness and causes some colors to overexpose?

Yes, there is a big quad (sprite) if front of the Sun.

[375gnu]

That's how it looks with stars as scaled disks (in this mode the quad size is much smaller):

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[375gnu]

btw, in old HDR code atmosphere is disabled:

#ifndef USE_HDR
        Atmosphere atmosphere;

        // Use atmosphere effect to give stars a fuzzy fringe
        if (star.hasCorona() && rp.geometry == InvalidResource)
        {
            Color atmColor(color.red() * 0.5f, color.green() * 0.5f, color.blue() * 0.5f);
            atmosphere.height = radius * CoronaHeight;
            atmosphere.lowerColor = atmColor;
            atmosphere.upperColor = atmColor;
            atmosphere.skyColor = atmColor;

            rp.atmosphere = &atmosphere;
        }
        else
#endif
        rp.atmosphere = NULL;

[AstroChara]

That's how it looks with stars as scaled disks (in this mode the quad size is much smaller):

What would this look like if used with a normal brightness star texture?

[375gnu]

What would this look like if used with a normal brightness star texture?

or even

[AstroChara]

What would this look like if used with a normal brightness star texture?

or even

Yup that looks lovely. Feels like we can actually use normal brightness textures in default now.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[AstroChara]

Looks like this is mostly done; I believe we mainly have to get new star textures to replace the current textures which have been darkened (and which have license issues)?

[375gnu]

Looks like this is mostly done; I believe we mainly have to get new star textures to replace the current textures which have been darkened (and which have license issues)?

if i remember correctly, yes, textures are main blocker

[pedro-fixingstuff]

Might be a good idea to write down how the coefficients were obtained.