Skip to content

Conversation

@aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Mar 5, 2025

  • delete a bunch of sharev2 code (and corresponding tests) that we don't need/use anymore
  • update existing code/tests to be ok with those deletions

@aaxelb aaxelb changed the title gizmob 2025-03-05 [wip][gizmob] share clean(up)grade Mar 5, 2025
@aaxelb aaxelb force-pushed the mob/2025-03-05 branch 2 times, most recently from 8839016 to ecc507c Compare March 7, 2025 16:15
@aaxelb aaxelb force-pushed the mob/2025-03-05 branch 4 times, most recently from 5407207 to a31b2a7 Compare March 7, 2025 17:18
aaxelb added 2 commits March 7, 2025 13:46
- bump actions/setup-python to v5
- bump actions/checkout to v4
- update postgres version(s)
- remove pin on coverallsapp/github-action, update to latest v2
- work around coveralls error; build and specify xml explicitly
- omit `tests/` from coverage calculation
@aaxelb aaxelb changed the title [wip][gizmob] share clean(up)grade [wip][gizmob] share clean(up)grade [ENG-7388][ENG-7389][ENG-7390] Mar 11, 2025
@aaxelb aaxelb changed the title [wip][gizmob] share clean(up)grade [ENG-7388][ENG-7389][ENG-7390] [gizmob] share clean(up)grade [ENG-7388][ENG-7389][ENG-7390] Mar 11, 2025
@aaxelb aaxelb marked this pull request as ready for review March 11, 2025 18:45
@aaxelb aaxelb requested review from felliott and futa-ikeda March 12, 2025 18:23
Copy link
Member

@felliott felliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! ✂️ ⚔️ 🔪 👍

@aaxelb aaxelb merged commit 654423d into CenterForOpenScience:feature/share-cleanupgrade-2025 Mar 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants