[ENG-7391] Cleanup, remove sharectl and share.bin.* #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
requested changes
Mar 12, 2025
Contributor
There was a problem hiding this comment.
left comments on the last commit (few requests, mostly looks good!)
could you rebase that one commit onto the feature branch? looks like it'll go cleanly
$ git rebase HEAD~ feature/cleanup_remove_sharectl --onto upstream/feature/share-cleanupgrade-2025
Successfully rebased and updated refs/heads/feature/cleanup_remove_sharectl.
bodintsov
force-pushed
the
feature/cleanup_remove_sharectl
branch
from
18bf48b to
a4ffaf7
Compare
aaxelb
requested changes
Mar 13, 2025
Contributor
aaxelb
left a comment
aaxelb
left a comment
There was a problem hiding this comment.
let's aim for passing tests (tho flake8 caught it sooner, two tests give NameError when run)
aaxelb
merged commit 3b35af3
into
CenterForOpenScience:feature/share-cleanupgrade-2025
2 of 3 checks passed
aaxelb
added a commit
to aaxelb/helm-charts
that referenced
this pull request
Mar 13, 2025
`sharectl` was removed in favor of django management commands; see CenterForOpenScience/SHARE#849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openscience.atlassian.net/browse/ENG-7391