style(addons): Update redirect language (#848)

Author: futa-ikeda

src/app/shared/components/addons/addon-terms/addon-terms.component.html

@@ -2,13 +2,12 @@
   <p class="mb-4">
     {{ 'settings.addons.connectAddon.redirectAddons.terms' | translate }}
   </p>
-  <em
-    class="ml-2"
+  <p
     [innerHTML]="
       'settings.addons.connectAddon.redirectAddons.tip'
         | translate: { serviceName: addon()?.displayName, serviceUrl: redirectUrl() }
     "
-  ></em>
+  ></p>
 } @else {
   <p-table [value]="terms()" class="addon-table">
     <ng-template pTemplate="header">

src/app/shared/components/addons/addon-terms/addon-terms.component.spec.ts

@@ -231,8 +231,7 @@ describe('AddonTermsComponent', () => {
 
     const termsElement: HTMLElement = fixture.nativeElement;
     expect(termsElement.querySelectorAll('tr').length).toBe(0);
-    expect(termsElement.querySelectorAll('p').length).toBe(1);
-    expect(termsElement.querySelectorAll('em').length).toBe(1);
+    expect(termsElement.querySelectorAll('p').length).toBe(2);
     expect(termsElement.textContent).toContain('settings.addons.connectAddon.redirectAddons.terms');
   });
 });

src/assets/i18n/en.json

@@ -1762,8 +1762,8 @@
         },
         "redirectAddons": {
           "terms": "Clicking the button below will redirect you outside of OSF. You will need to follow that service's permissions to continue.",
-          "tip": "Tip: if the page does not open, please disable your browser's pop-up blocker and try again. Or click on this link to <a target='_blank' href={{serviceUrl}}>go to {{serviceName}}</a>.",
-          "popupError": "If you are having trouble with the pop-up window, please try clicking the link above to connect your account:",
+          "tip": "If the page does not open, disable your browser's pop-up blocker and try again. Or click on this link to <a target='_blank' href={{serviceUrl}}>go to {{serviceName}}</a>.",
+          "popupError": "If you are having trouble with the pop-up window, try clicking the link above to connect your account:",
           "goToService": "Go to {{serviceName}}"
         },
         "confirmAccount": "Confirm account",