Skip to content

style(addons): Update redirect language #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futa-ikeda merged 1 commit into from
Jan 9, 2026
Merged

style(addons): Update redirect language #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/app/shared/components/addons/addon-terms/addon-terms.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
<p class="mb-4">
{{ 'settings.addons.connectAddon.redirectAddons.terms' | translate }}
</p>
<em
class="ml-2"
<p
[innerHTML]="
'settings.addons.connectAddon.redirectAddons.tip'
| translate: { serviceName: addon()?.displayName, serviceUrl: redirectUrl() }
"
></em>
></p>
} @else {
<p-table [value]="terms()" class="addon-table">
<ng-template pTemplate="header">
Expand Down
3 changes: 1 addition & 2 deletions src/app/shared/components/addons/addon-terms/addon-terms.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,7 @@ describe('AddonTermsComponent', () => {

const termsElement: HTMLElement = fixture.nativeElement;
expect(termsElement.querySelectorAll('tr').length).toBe(0);
expect(termsElement.querySelectorAll('p').length).toBe(1);
expect(termsElement.querySelectorAll('em').length).toBe(1);
expect(termsElement.querySelectorAll('p').length).toBe(2);
expect(termsElement.textContent).toContain('settings.addons.connectAddon.redirectAddons.terms');
});
});
4 changes: 2 additions & 2 deletions src/assets/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,8 +1762,8 @@
},
"redirectAddons": {
"terms": "Clicking the button below will redirect you outside of OSF. You will need to follow that service's permissions to continue.",
"tip": "Tip: if the page does not open, please disable your browser's pop-up blocker and try again. Or click on this link to <a target='_blank' href={{serviceUrl}}>go to {{serviceName}}</a>.",
"popupError": "If you are having trouble with the pop-up window, please try clicking the link above to connect your account:",
"tip": "If the page does not open, disable your browser's pop-up blocker and try again. Or click on this link to <a target='_blank' href={{serviceUrl}}>go to {{serviceName}}</a>.",
"popupError": "If you are having trouble with the pop-up window, try clicking the link above to connect your account:",
"goToService": "Go to {{serviceName}}"
},
"confirmAccount": "Confirm account",
Expand Down