Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

  • Ticket: [No ticket]
  • Feature flag: n/a

Purpose

  • Fix an issue where the value-searches for a given filterable property were not being queried with any applied filters
  • Fix an issue where adding more affiliation filters was breaking

Summary of Changes

  • Pass all applied filters to value-searches
  • Update cardSearchFilter[affiliation] query-param to be an array, instead of a string

Screenshot(s)

  • defaultQueryParams.cardSearchFilter.affiliation not being an array lead to this misformatted request param (array.concat vs. string.concat)
    image

Side Effects

QA Notes

@futa-ikeda futa-ikeda changed the title Fix bug where value-searches did not contain all filters applied Fix value-search bugs Nov 12, 2024
@futa-ikeda futa-ikeda merged commit 1731732 into CenterForOpenScience:feature/insti-dash-improv Nov 12, 2024
@futa-ikeda futa-ikeda deleted the value-search-bug branch November 12, 2024 16:25
@futa-ikeda futa-ikeda added this to the 24.09.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants