Skip to content

[ENG-6599][ENG-6598] A11y #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futa-ikeda merged 1 commit into from
Nov 19, 2024
Merged

[ENG-6599][ENG-6598] A11y #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/institutions/dashboard/-components/institutional-users-list/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default class InstitutionalUsersList extends Component<InstitutionalUsers
// Private properties
@tracked hasOrcid = false;
@tracked totalUsers = 0;
orcidUrlPrefix = 'https://orcid.org/'; // Move to config?
orcidUrlPrefix = 'https://orcid.org/';

@action
toggleColumnSelection(columnKey: string) {
Expand Down
7 changes: 6 additions & 1 deletion app/institutions/dashboard/-components/institutional-users-list/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
<OsfLink
data-test-link-to-reports-archive
data-analytics-name='Link to archived reports'
aria-label={{t 'institutions.dashboard.download_past_reports_label'}}
@target='_blank'
@fakeButton={{true}}
@href={{@institution.linkToExternalReportsArchive}}
Expand All @@ -85,7 +86,11 @@
{{/if}}
<div local-class='download-dropdown'>
<ResponsiveDropdown @renderInPlace={{true}} @buttonStyling={{true}} as |dd| >
<dd.trigger data-test-download-dropdown local-class='download-dropdown-trigger'>
<dd.trigger
data-test-download-dropdown
aria-label={{t 'institutions.dashboard.download_dropdown_label'}}
local-class='download-dropdown-trigger'
>
<FaIcon @icon='download' />
</dd.trigger>
<dd.content local-class='download-dropdown-content'>
Expand Down
11 changes: 8 additions & 3 deletions app/institutions/dashboard/-components/object-list/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ as |list|>
<OsfLink
data-test-link-to-reports-archive
data-analytics-name='Link to archived reports'
aria-label={{t 'institutions.dashboard.download_past_reports_label'}}
@target='_blank'
@fakeButton={{true}}
@href={{@institution.linkToExternalReportsArchive}}
Expand All @@ -86,7 +87,11 @@ as |list|>
</div>
{{/if}}
<ResponsiveDropdown @renderInPlace={{true}} @buttonStyling={{true}} as |dd| >
<dd.trigger data-test-download-dropdown local-class='download-dropdown-trigger'>
<dd.trigger
data-test-download-dropdown
aria-label={{t 'institutions.dashboard.download_dropdown_label'}}
local-class='download-dropdown-trigger'
>
<FaIcon @icon='download' />
</dd.trigger>
<dd.content local-class='download-dropdown-content'>
Expand All @@ -97,8 +102,8 @@ as |list|>
{{t 'institutions.dashboard.format_labels.csv'}}
</Button>
<Button
local-class='download-option'
{{on 'click' (queue this.downloadTsv dd.close)}}
local-class='download-option'
{{on 'click' (queue this.downloadTsv dd.close)}}
>
{{t 'institutions.dashboard.format_labels.tsv'}}
</Button>
Expand Down
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/adjustable-paginator/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<span local-class='paginator__control'>
<div local-class='paginator__select-wrapper'>
<select id='pageSizeSelect' local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
<select title={{t 'paginator.itemsPerPage'}} local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
{{#each this.pageSizeOptions as |page_size_option|}}
<option value={{page_size_option}} selected={{eq page_size_option this.selectedPageSize}}>
{{t 'paginator.itemsPerPage'}} {{page_size_option}}
Expand Down
1 change: 1 addition & 0 deletions translations/en-us.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@ institutions:
content-placeholder: Content coming soon # Delete this eventually pls
title: '{institutionName} Dashboard'
download_past_reports_label: 'Previous reports'
download_dropdown_label: 'Download data'
download_csv: 'Download CSV'
download_tsv: 'Download TSV'
format_labels:
Expand Down