Skip to content

Cleanup commented out import and test #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futa-ikeda merged 1 commit into from
Nov 20, 2024
Merged

Cleanup commented out import and test #2409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions app/institutions/dashboard/-components/chart-kpi-wrapper/chart-kpi/component-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,31 +81,4 @@ module('Integration | institutions | dashboard | -components | chart-kpi', hooks
assert.dom('[data-test-expanded-total="0"]')
.hasText('100000');
});

/**
* I need to determine if this is going to be a feature or not
test('it renders the without data correctly', async function(this: EnginesIntlTestContext, assert) {
const data = Object({
total: 0,
title: 'This is the title',
icon: 'building',
});

this.set('data', data);


await render(hbs`
<Institutions::Dashboard::-Components::ChartKpiWrapper::ChartKpi
@data={{this.data}}
/>
`);

assert.dom('[data-test-kpi-title]')
.hasText('This is the title');
assert.dom('[data-test-kpi-data]')
.hasText('No data for institution found.');
assert.dom('[data-test-kpi-icon]')
.hasAttribute('data-icon', 'building');
});
*/
});
4 changes: 0 additions & 4 deletions app/institutions/dashboard/-components/chart-kpi-wrapper/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ import InstitutionDepartmentModel from 'ember-osf-web/models/institution-departm
import InstitutionSummaryMetricModel from 'ember-osf-web/models/institution-summary-metric';
import SearchResultModel from 'ember-osf-web/models/search-result';

/*
import InstitutionSummaryMetricModel from 'ember-osf-web/models/institution-summary-metric';
*/

export interface ChartDataModel {
label: string;
total: number;
Expand Down
Loading