Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

  • Ticket: []
  • Feature flag: n/a

Purpose

  • Fix contributor fields that were broken on test

Summary of Changes

  • Account for some affiliations that do no have an identifier field and fall back to using the @id property to check affiliation

Screenshot(s)

  • Example of two affiliations, one with the identifier attribute and the other with no identifier attribute (this second one would cause the page to break):
    image

  • Before:
    image

  • After:
    image

Side Effects

QA Notes

@futa-ikeda futa-ikeda changed the base branch from master to hotfix/24.09.1 November 21, 2024 17:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11958601673

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 64.836%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/institutions/dashboard/-components/object-list/contributors-field/component.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 11958639544: -0.004%
Covered Lines: 6933
Relevant Lines: 10277

💛 - Coveralls

@futa-ikeda futa-ikeda merged commit 15ba724 into CenterForOpenScience:hotfix/24.09.1 Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants