[ENG-8159] Allow collections without metadata to be submitted. #2567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
approved these changes
Jun 3, 2025
Contributor
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
This was a fun one to debug 😬
Comment on lines
+14
to
+15
| const { data, data: { relationships } } = serialized; | ||
| data.attributes = data.attributes || { }; |
Contributor
There was a problem hiding this comment.
For future reference, in the case where the provider has no collection-specific metadata (no issue, volume, studyDesign, etc), the collection-submissionhas no attributes, only relationships. So in this case,data.attributesisundefined`, so we need to instantiate it as an empty object
brianjgeiger
changed the base branch from
feature/pbs-25-10
to
feature/pbs-25-12
Contributor
|
@brianpilati Could you rebase this on |
brianjgeiger
changed the base branch from
feature/pbs-25-12
to
feature/pbs-25-10
Contributor
|
Closed in favor of #2596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Collections without meta-data were throwing errors because the
attributesobject was null.Summary of Changes
If the
attributesobject is null then it is instantiated with an empty objectScreenshot(s)
N.A
Side Effects
Lots regarding the user experience which I have documented for Mark.
QA Notes
You will need to turn off all metadata in the admin before testing