[ENG-8235] Fix link addon reconfiguration #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
approved these changes
Jun 19, 2025
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Looks good and verified locally ⭐ . Left a couple of questions.
| import { tracked } from 'tracked-built-ins'; | ||
| import { taskFor } from 'ember-concurrency-ts'; | ||
| import { SupportedResourceTypes } from 'ember-osf-web/models/external-link-service'; | ||
| // import ConfiguredLinkAddonModel from 'ember-osf-web/models/configured-link-addon'; |
Collaborator
There was a problem hiding this comment.
Any considerations for keeping this?
Comment on lines
+55
to
+60
| @task | ||
| @waitFor | ||
| async getSelectedItemName(this: ConfiguredCitationAddonModel) { | ||
| const response = await taskFor(this.getItemInfo).perform(this.rootFolder); | ||
| this.rootFolderName = (response.operationResult as Item).itemName; | ||
| } |
Collaborator
There was a problem hiding this comment.
Non-blocking: should we define this back in configured-addon.ts while overriding it in `configured-link-addon? In this way, we won't have duplicate code for storage and citation add-ons.
cslzchen
merged commit aea44b7
into
CenterForOpenScience:feature/verified-resource-linking
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes