[ENG-8266] Fix "linked item" for linked service configuration #2591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Some test failures. And also there is another commit from @opaduchak that doesn't seem to be related to this ticket? Or is this PR for two different tickets? |
Collaborator
Author
|
Yes, the extra commit is to test if Oleh's commit fails consistently on the same error across different PRs ... which I will remove before merge. |
cslzchen
force-pushed
the
feature/no-item-selected
branch
from
f50cf69 to
a377f58
Compare
cslzchen
merged commit a6a0902
into
CenterForOpenScience:feature/verified-resource-linking
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When no dataverse, dataset or file is connected, "linked item" should say "no item selected" instead of "no folder selected".
Summary of Changes
When no dataverse, dataset or file is connected, "linked item" should say "no item selected" instead of "no folder selected".
Screenshot(s)
Side Effects
N/A
QA Notes
N/A