Skip to content

[ENG-8255][ENG-8244] Show item name when deleting linked service; fix linked service page for mobile #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cslzchen merged 2 commits into from
Jun 24, 2025
Merged

[ENG-8255][ENG-8244] Show item name when deleting linked service; fix linked service page for mobile #2593

cslzchen merged 2 commits into from
Jun 24, 2025

Conversation

@adlius
Copy link
Contributor

@adlius adlius commented Jun 24, 2025 •
edited by atlassian bot
Loading

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

@adlius adlius changed the title [ENG-8244] Show target item name for ConfiguredLinkAddons when deleting the addon. [ENG-8255][ENG-8244] Show target item name for ConfiguredLinkAddons when deleting the addon. Jun 24, 2025
@adlius adlius changed the title [ENG-8255][ENG-8244] Show target item name for ConfiguredLinkAddons when deleting the addon. [ENG-8255][ENG-8244] Show target item name for ConfiguredLinkAddons when deleting the addon; CSS fix for mobile Jun 24, 2025
cslzchen
cslzchen requested changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Mobile view looks good and waiting to hear back from Product approved by Product
  • Target item works for dataverse and file but not for dataset, please take another look. It may be a BE bug though but please confirm. GV issue, fixed

cslzchen
cslzchen approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugged locally and it's a BE bug ... same addon-operation-invocations ones we had before ... so this PR looks good 🎆

Screenshot 2025-06-24 at 12 36 49

Screenshot 2025-06-24 at 12 04 30

Screenshot 2025-06-24 at 12 02 32

@cslzchen cslzchen changed the title [ENG-8255][ENG-8244] Show target item name for ConfiguredLinkAddons when deleting the addon; CSS fix for mobile [ENG-8255][ENG-8244] Show item name when deleting linked service; fix linked service page for mobile (#2593) Jun 24, 2025
@cslzchen cslzchen changed the title [ENG-8255][ENG-8244] Show item name when deleting linked service; fix linked service page for mobile (#2593) [ENG-8255][ENG-8244] Show item name when deleting linked service; fix linked service page for mobile Jun 24, 2025
@cslzchen cslzchen merged commit 7d1c063 into CenterForOpenScience:feature/verified-resource-linking Jun 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cslzchen cslzchen cslzchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adlius @cslzchen