Skip to content

[ENG-7805] Fix to prevent a race-condition removing a supplement from a preprint #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bp-cos merged 2 commits into from
Jun 24, 2025
Merged

[ENG-7805] Fix to prevent a race-condition removing a supplement from a preprint #2594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15543ed
Added fix to break a race-condition error
bp-cos Jun 23, 2025
aa96b7e
Refactor to use the abstracted method
bp-cos Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/preprints/-components/submit/supplements/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export default class Supplements extends Component<SupplementsArgs>{
@waitFor
public async removeSelectedProject(): Promise<void> {
try {
this.validate(false);
await this.args.manager.preprint.removeM2MRelationship('node'); // Remove relationship
// Remove relationship on the node side, this only clears the cache locally
this.args.manager.preprint.node.get('preprints')
Expand All @@ -89,7 +90,7 @@ export default class Supplements extends Component<SupplementsArgs>{
}

@action
public validate(): void {
this.args.manager.validateSupplements(true);
public validate(isValid = true): void {
this.args.manager.validateSupplements(isValid);
}
}