Skip to content

[ENG-8060] Fix redundant unless #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adlius merged 1 commit into from
Jul 7, 2025
Merged

[ENG-8060] Fix redundant unless #2597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 33 additions & 39 deletions app/guid-node/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,55 +99,49 @@
@label={{t 'node.left_nav.registrations'}}
/>
{{/unless}}
{{#unless this.currentUser.viewOnlyToken}}
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
<leftNav.link
data-test-contributors-link
data-analytics-name='Contributors'
@href='/{{this.model.taskInstance.value.id}}/contributors/'
@icon='users'
@label={{t 'node.left_nav.contributors'}}
/>
{{#if this.useGravyWaffle}}
<leftNav.link
data-test-contributors-link
data-analytics-name='Contributors'
@href='/{{this.model.taskInstance.value.id}}/contributors/'
@icon='users'
@label={{t 'node.left_nav.contributors'}}
data-test-addons-link
data-analytics-name='Add-ons'
@route='guid-node.addons'
@models={{array this.model.taskInstance.value.id}}
@icon='database'
@label={{t 'node.left_nav.add-ons'}}
/>
{{else}}
<leftNav.link
data-test-addons-link
data-analytics-name='Add-ons'
@href='/{{this.model.taskInstance.value.id}}/addons/'
@icon='database'
@label={{t 'node.left_nav.add-ons'}}
/>
{{/if}}
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasWritePermission)}}
{{#if this.useGravyWaffle}}
<leftNav.link
data-test-addons-link
data-analytics-name='Add-ons'
@route='guid-node.addons'
@models={{array this.model.taskInstance.value.id}}
@icon='database'
@label={{t 'node.left_nav.add-ons'}}
/>
{{else}}
<leftNav.link
data-test-addons-link
data-analytics-name='Add-ons'
@href='/{{this.model.taskInstance.value.id}}/addons/'
@icon='database'
@label={{t 'node.left_nav.add-ons'}}
/>
{{/if}}
{{/if}}
{{/unless}}
{{/if}}
<leftNav.link
data-test-verified-links-link
data-analytics-name='Linked services'
@route='guid-node.links'
@icon='link'
@label={{t 'node.left_nav.links'}}
/>
{{#unless this.currentUser.viewOnlyToken}}
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
<leftNav.link
data-test-settings-link
data-analytics-name='Settings'
@href='/{{this.model.taskInstance.value.id}}/settings/'
@icon='cogs'
@label={{t 'node.left_nav.settings'}}
/>
{{/if}}
{{/unless}}
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
<leftNav.link
data-test-settings-link
data-analytics-name='Settings'
@href='/{{this.model.taskInstance.value.id}}/settings/'
@icon='cogs'
@label={{t 'node.left_nav.settings'}}
/>
{{/if}}
</layout.leftNavOld>
<layout.main local-class='OverviewBody'>
<div data-analytics-scope='Node' role='main'>
Expand Down