Skip to content

[ENG-8363] Add resource type helper #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adlius merged 3 commits into from
Jul 10, 2025
Merged

[ENG-8363] Add resource type helper #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
456bc24
add helper
adlius Jul 9, 2025
d1e8081
moar fix
adlius Jul 10, 2025
bad1fe7
add aria label translation string
adlius Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export default class ConfiguredAddonEdit extends Component<Args> {
@tracked selectedResourceType = '';
@tracked isWBGoogleDrive = false;
@tracked accountId!: string;
@tracked isResourceTypeDialogOpen = false;

originalName = this.displayName;
originalRootFolder = this.selectedFolder;
Expand Down
31 changes: 31 additions & 0 deletions lib/osf-components/addon/components/addons-service/configured-addon-edit/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,13 @@
{{#if this.isLinkAddon}}
<label>
{{t 'addons.configure.resource-type'}}
<Button
aria-label={{t 'addons.configure.resource-type-helper-aria-label'}}
@layout='fake-link'
{{on 'click' (fn (mut this.isResourceTypeDialogOpen) true)}}
>
<FaIcon @icon='question-circle' />
</Button>
<PowerSelect
@options={{@supportedResourceTypes}}
@selected={{this.selectedResourceType}}
Expand Down Expand Up @@ -200,3 +207,27 @@
</Button>
</div>
</div>

<OsfDialog
@isOpen={{this.isResourceTypeDialogOpen}}
@onClose={{action (mut this.isResourceTypeDialogOpen) false}}
@closeOnOutsideClick={{true}}
as |dialog|
>
<dialog.heading>
{{t 'addons.configure.resource-type-helper-header'}}
</dialog.heading>
<dialog.main tabindex='0'>
{{t 'addons.configure.resource-type-helper-body'
htmlSafe=true
}}
</dialog.main>
<dialog.footer>
<Button
@type='secondary'
{{on 'click' dialog.close}}
>
{{t 'general.close'}}
</Button>
</dialog.footer>
</OsfDialog>
3 changes: 3 additions & 0 deletions translations/en-us.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,9 @@ addons:
heading: 'Configure {providerName}'
resource-type: 'Resource type'
resource-type-placeholder: 'Choose a resource type'
resource-type-helper-aria-label: 'More information about resource types'
resource-type-helper-header: 'About resource type'
resource-type-helper-body: 'This helps others understand what kind of material you''re sharing. Choosing the right resource type makes it easier for search engines and research tools to find and share your work—both on OSF and in other scholarly indexes.<br><br>For example, selecting <b>“Dataset”</b> tells tools and repositories that your files are research data, which helps your work appear in places that specialize in datasets.<br><br>Pick the option that best describes most of the files you''re linking.<br><br>OSF uses resource types from <b>DataCite</b>, a standard used by many research platforms. <a target="_blank" rel="noopener noreferrer" href="https://help.osf.io/article/570-resource-types-in-osf">(Learn more)</a>'
display-name: 'Display name'
selected-folder: 'Selected folder:'
linked-item: 'Linked item:'
Expand Down