Skip to content

fix helper button issue #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adlius merged 2 commits into from
Jul 10, 2025
Merged

fix helper button issue #2600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc62b1
fix helper button issue
adlius Jul 10, 2025
39a3c41
one more
adlius Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/guid-node/links/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
{{else}}
<p>{{t 'links.empty-screen-message'}}</p>
{{#if this.currentUserCanEdit}}
<p> {{t 'links.point-to-addons-message'}} <a href='/{{this.model.node.id}}/addons?activeFilterType=verified-link'>{{t 'addons.heading'}}</a></p>
<p> {{t 'links.point-to-addons-message-1'}} <a href='/{{this.model.node.id}}/addons?activeFilterType=verified-link'>{{t 'addons.heading'}}</a>{{t 'links.point-to-addons-message-2'}}</p>
{{/if}}
{{/if}}
</div>
4 changes: 4 additions & 0 deletions lib/osf-components/addon/components/addons-service/configured-addon-edit/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,7 @@
white-space: pre-wrap;

}

.trigger {
width: 130px;
}
24 changes: 14 additions & 10 deletions lib/osf-components/addon/components/addons-service/configured-addon-edit/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,25 +167,29 @@
></GoogleFilePickerWidget>
{{/if}}
{{#if this.isLinkAddon}}
<label>
{{t 'addons.configure.resource-type'}}
<Button
aria-label={{t 'addons.configure.resource-type-helper-aria-label'}}
@layout='fake-link'
{{on 'click' (fn (mut this.isResourceTypeDialogOpen) true)}}
>
<FaIcon @icon='question-circle' />
</Button>
{{#let (unique-id 'resource-type') as |resourceTypeId|}}
<label for={{resourceTypeId}}>
{{t 'addons.configure.resource-type'}}
<Button
aria-label={{t 'addons.configure.resource-type-helper-aria-label'}}
@layout='fake-link'
{{on 'click' (fn (mut this.isResourceTypeDialogOpen) true)}}
>
<FaIcon @icon='question-circle' />
</Button>
</label>
<PowerSelect
id={{resourceTypeId}}
@options={{@supportedResourceTypes}}
@selected={{this.selectedResourceType}}
@onChange={{action (mut this.selectedResourceType)}}
@triggerClass={{local-class 'trigger'}}
@placeholder={{t 'addons.configure.resource-type-placeholder'}}
as |resourceType|
>
{{resourceType}}
</PowerSelect>
</label>
{{/let}}
{{/if}}
<div local-class='footer-buttons-wrapper'>
<Button
Expand Down
3 changes: 2 additions & 1 deletion translations/en-us.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,8 @@ links:
display-name: 'Display Name'
resource-type: 'Resource Type'
empty-screen-message: 'This project has no configured linked services at the moment '
point-to-addons-message: 'In order to add linked service visit'
point-to-addons-message-1: 'Visit '
point-to-addons-message-2: ' to add a linked service.'
link: 'Link'
edit: 'Edit'
icon: '{addonName} icon'
Expand Down