Skip to content

[eng-8074] Added an enabled true/false to prevent a race condition #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bp-cos merged 3 commits into from
Jul 17, 2025
Merged

[eng-8074] Added an enabled true/false to prevent a race condition #2602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
887fa0d
Added an enabled true/false to prevent a race condition
bp-cos Jul 16, 2025
1a47a50
Removed the unnecessary @enabled pass through variable
bp-cos Jul 16, 2025
22ae1b8
Forgot to save the template
bp-cos Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/preprints/-components/submit/file/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
@manager={{@manager}}
@preprint={{@manager.preprint}}
@clickableElementId={{id}}
@enable={{true}}
@dragEnter={{fn (mut this.dragging) true}}
@dragOver={{fn (mut this.dragging) true}}
@dragLeave={{fn (mut this.dragging) false}}
Expand Down
2 changes: 2 additions & 0 deletions app/preprints/-components/submit/file/upload-file/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export default class PreprintUpload extends Component<PreprintUploadArgs> {
rootFolder?: FileModel;
primaryFile: FileModel | undefined;
@tracked isUploadFileDisplayed = false;
@tracked isEnabled = false;

constructor(owner: unknown, args: any) {
super(owner, args);
Expand Down Expand Up @@ -75,6 +76,7 @@ export default class PreprintUpload extends Component<PreprintUploadArgs> {

this.url = new URL( urlString );
this.rootFolder = rootFolder;
this.isEnabled = true;
}

@action
Expand Down
2 changes: 1 addition & 1 deletion app/preprints/-components/submit/file/upload-file/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
@dragleave={{@dragLeave}}
@dragover={{@dragOver}}
@drop={{@drop}}
@enable={{@enable}}
@enable={{this.isEnabled}}
@id={{id}}
@clickable={{this.clickableElementSelectors}}
@preUpload={{perform this.preUpload}}
Expand Down