Skip to content

[DRAFT] lift 1 configured addon per service constraint for link #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opaduchak wants to merge 1 commit into
base: feature/verified-resource-linking
Choose a base branch
from
Open

[DRAFT] lift 1 configured addon per service constraint for link #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addon_service/configured_addon/link/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class ConfiguredLinkAddonSerializer(ConfiguredAddonSerializer):
class Meta:
model = ConfiguredLinkAddon
read_only_fields = ["external_link_service"]
one_addon_per_node = False
fields = [
"id",
"display_name",
Expand Down
13 changes: 9 additions & 4 deletions addon_service/configured_addon/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,14 @@ def get_current_user_is_owner(self, configured_addon: ConfiguredAddon):
def create(self, validated_data):
validated_data = self.fix_dotted_base_account(validated_data)
base_account = validated_data["base_account"]
if ConfiguredAddon.objects.filter(
base_account__external_service=base_account.external_service,
authorized_resource__resource_uri=validated_data["resource_uri"],
).exists():
validate_one_addon = getattr(self.Meta, "one_addon_per_node", True)
if (
validate_one_addon
and ConfiguredAddon.objects.filter(
base_account__external_service=base_account.external_service,
authorized_resource__resource_uri=validated_data["resource_uri"],
).exists()
):
raise ValidationError(
f"ConfiguredAddon for requested addon and authorized_resource {validated_data['resource_uri']} already exists"
)
Expand All @@ -61,6 +65,7 @@ def update(self, instance, validated_data):
class Meta:
resource_name = "configured-addons"
model = ConfiguredAddon
one_addon_per_node = True
fields = [
"id",
"url",
Expand Down