[WIP] [SVCS-325] Proof of concept: Notify users after returning a 202 Accepted?#226
Open
TomBaxter wants to merge 1 commit intoCenterForOpenScience:developfrom
TomBaxter:feature/svcs-325
Open
[WIP] [SVCS-325] Proof of concept: Notify users after returning a 202 Accepted?#226TomBaxter wants to merge 1 commit intoCenterForOpenScience:developfrom TomBaxter:feature/svcs-325
TomBaxter wants to merge 1 commit intoCenterForOpenScience:developfrom
TomBaxter:feature/svcs-325
Conversation
Task returns "Content-Location" header along with 202 Content-Location points to new /pending end-point Upon task completion /pending end-point return 303 and "Content-Location" header Pending Content-Location header returns uri of created/updated resource.
cslzchen
requested changes
Jun 27, 2018
Contributor
There was a problem hiding this comment.
-
Currently we inform the users of the success/failure by sending them an email upon finish/error. Does this solve the needs already? Or we want something more here? The original analysis ticket dated back to 2015 but the most recent one was just a year old. This makes me wonder whether there is still a need or not.
-
This PR and it's OSF counterpart seems unfinished. In addition, The page which provides some insight on the initial investigation for this PR seems unfinished as well. I am not able to get a general idea of the approach taken here and I don't know how Redis helps here. Need more discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task returns "Content-Location" header along with 202
Content-Location points to new /pending end-point
Upon task completion /pending end-point return 303 and "Content-Location" header
Pending Content-Location header returns uri of created/updated resource.
Requires redis. OSF PR 7255
[#SVCS-325]