Skip to content

[SVCS-552] folder_file_op cut down revalidate calls. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Johnetordoff wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[SVCS-552] folder_file_op cut down revalidate calls. #311

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaff576
Add the id property to core and provider metadata
Johnetordoff Dec 20, 2017
bf5f9e3
Add/update tests/fixtures for metadata id property
Johnetordoff Dec 20, 2017
a27b568
Replace unnecessary path revalidation
Johnetordoff Dec 20, 2017
63825aa
Add the `id` property to GoogleCloud metadata
cslzchen May 30, 2018
b61b2ec
Update docstring, comments and todos
cslzchen May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions waterbutler/providers/googlecloud/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ class BaseGoogleCloudMetadata(metadata.BaseMetadata, metaclass=abc.ABCMeta):
def provider(self) -> str:
return 'googlecloud'

@property
def id(self) -> str:
Copy link
Copy Markdown
Contributor

@cslzchen cslzchen May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add GoogleCloud to pass tests.

return self.path

@property
def path(self) -> str:
return self.build_path(self.raw.get('object_name', None))
Expand Down