Rework move_copy/intra_move_copy#354
Open
NyanHelsing wants to merge 1 commit intoCenterForOpenScience:developfrom
Open
Rework move_copy/intra_move_copy#354NyanHelsing wants to merge 1 commit intoCenterForOpenScience:developfrom
NyanHelsing wants to merge 1 commit intoCenterForOpenScience:developfrom
Conversation
NyanHelsing
force-pushed
the
ft/clarify-move_copy-logic
branch
from
b41fa85 to
9c9190b
Compare
Clarifies the code used to check if the move or copy can be don on the provider, or if waterbutler needs to do it. Also refactors a function that had a bit of a weird signature so we don't need a comment justifying it.
NyanHelsing
force-pushed
the
ft/clarify-move_copy-logic
branch
from
9c9190b to
73145b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
No ticket
Purpose
Clarifies the code used to check if the move or copy can be don on the
provider, or if waterbutler needs to do it. Also refactors a function
that had a bit of a weird signature so we don't need a comment
justifying it.
Changes
Add comments, invert order of if condition
Side effects
Doubtful
QA Notes
N/A
Deployment Notes
N/A